Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Replace most usage of SimulatedNulls #16734

Merged
merged 7 commits into from
Sep 13, 2024
Merged

VReplication: Replace most usage of SimulatedNulls #16734

merged 7 commits into from
Sep 13, 2024

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Sep 9, 2024 •
edited
Loading

Description

This leverages the new go protobuf optional support for everything but slices (repeated <type>), where there's still no support for pointers to slices (double pointer) — which is needed as a nil slice == an empty slice — so we still need a way to distinguish an intentionally empty slice (remove/clear existing values) from an unspecified slice (I'm not providing a new value so don't update it).

ToDo:

  • Confirm that these changes are backward/forward compatible:
git checkout main
make build

pushd examples/local
alias vtctldclient='command vtctldclient --server=localhost:15999'

./101_initial_cluster.sh

popd

git checkout rm_simulated_nulls
make build

pushd examples/local

./201_customer_tablets.sh; ./202_move_tables.sh

vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i on_ddl
vtctldclient workflow --keyspace customer update --workflow commerce2customer --on-ddl EXEC
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i on_ddl
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i -A4 types
vtctldclient workflow --keyspace customer update --workflow commerce2customer --tablet-types="primary"
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i -A4 types
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i on_ddl
vtctldclient workflow --keyspace customer update --workflow commerce2customer --tablet-types="primary,replica" --tablet-types-in-order
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i on_ddl
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i -A4 types
vtctldclient workflow --keyspace customer update --workflow commerce2customer --tablet-types="primary,replica" --tablet-types-in-order=false
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i -A4 types
vtctldclient workflow --keyspace customer update --workflow commerce2customer --tablet-types="primary,replica" --tablet-types-in-order
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i -A4 types
vtctldclient workflow --keyspace customer show --workflow commerce2customer --compact | grep -i -A2 cells
vtctldclient workflow --keyspace customer update --workflow commerce2customer --cells="zone1"
vtctldclient workflow --keyspace customer show --workflow commerce2customer --compact | grep -i -A2 cells
vtctldclient workflow --keyspace customer update --workflow commerce2customer --cells=""
vtctldclient workflow --keyspace customer show --workflow commerce2customer --compact | grep -i -A2 cells
vtctldclient workflow --keyspace customer show --workflow commerce2customer | grep -i -A4 types

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@mattlord mattlord added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication labels Sep 9, 2024
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Sep 9, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Sep 9, 2024
@mattlord mattlord removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Sep 9, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Sep 9, 2024
@mattlord
Update unit test
1a145a5 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Changes from self review
5e3054b 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Update vexec unit test
6323ffa 
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label Sep 9, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 51.42857% with 17 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (5d562c7) to head (8aba9e4).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ctldclient/command/vreplication/workflow/update.go 0.00% 4 Missing ⚠️
go/vt/vtadmin/api.go 0.00% 4 Missing ⚠️
go/vt/vtctl/vtctl.go 0.00% 4 Missing ⚠️
...vtctldclient/command/vreplication/common/update.go 0.00% 2 Missing ⚠️
...tctldclient/command/vreplication/workflow/state.go 0.00% 2 Missing ⚠️
go/vt/vtctl/workflow/resharder.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #16734      +/-   ##
==========================================
+ Coverage   68.91%   68.93%   +0.02%     
==========================================
  Files        1565     1565              
  Lines      201685   201719      +34     
==========================================
+ Hits       138995   139063      +68     
+ Misses      62690    62656      -34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord mattlord marked this pull request as ready for review September 9, 2024 04:01
@mattlord mattlord force-pushed the rm_simulated_nulls branch 2 times, most recently from 965bdbd to 6323ffa Compare September 9, 2024 04:40
@mattlord mattlord mentioned this pull request Sep 13, 2024
Merged
5 tasks
notfelineit
notfelineit approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@notfelineit notfelineit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vtctld + vtadmin parts look good to me!

@mattlord mattlord merged commit 646bfd4 into vitessio:main Sep 13, 2024
130 checks passed
@mattlord mattlord deleted the rm_simulated_nulls branch September 13, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@notfelineit notfelineit notfelineit approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Replace SimulatedNull code with new protobuf optionals
3 participants
@mattlord @notfelineit @rohit-nayak-ps